Sourcetrail fails to find implicit destructor calls

petermost / Sourcetrail

Sourcetrail - free and open-source interactive source explorer

http://Sourcetrail.de

GNU General Public License v3.0

55 stars 1 forks source link

Sourcetrail fails to find implicit destructor calls #7

Open petermost opened 4 months ago

petermost commented 4 months ago

Copied from Sourcetrail issue: https://github.com/CoatiSoftware/Sourcetrail/issues/839

Sourcetrail does not appear to find implicit destructor calls.

Being able to find destructor calls would be immensely helpful.

In the mean time, at the least it would be helpful for Sourcetrail to provide a warning message that it does not expect to find them.

petermost commented 4 months ago

@catskul: The current indexer only uses the Clang AST, which doesn't provide that information. This Stackoverflow answer "How to get information about call to destructors in Clang LibTooling?" shows that it is necessary to use the 'Control Flow Graph' (CFG) to retrieve that information.

petermost commented 4 months ago

Added with commit https://github.com/petermost/Sourcetrail/commit/0beeaa070e45aada883af9204bf35397c25fa8a6

Please note:

Only non-trivial destructors are being indexed, because only those are detectable via CFG.
The source code location of the destructor call is always at the end of the function, because the CFG doesn't offer locations.

Maybe @mlangkabel or @egraether have a better idea, but they probably don't have time to support a Sourcetrail clone.

petermost commented 3 months ago

Disabled the detection/indexing of the destructor calls with commit https://github.com/petermost/Sourcetrail/commit/bccad3b50423167fcd673f8c9a0d1d9fad3af0e8 because of a crash (assertion) in CFG::buildCFG