search

petermr / ami3

Integration of cephis and normami code into a single base. Tests will be slimmed down
Apache License 2.0
17 stars 5 forks source link

Hyperlink DOIs to preferred resolver #6

Open katrinleinweber opened 4 years ago

katrinleinweber commented 4 years ago

Follow-up to https://github.com/ContentMine/norma/pull/75. I search-and-replaced automatically, so I might have caught DOI strings that might be more useful to keep in the old form. In tests maybe?

Also, b2a04e4 & fbee50d update a DOI reg-ex to hopefully be more useful.

I ran mvn clean install and saw no DOI-related errors, but:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project ami3: Compilation failure
[ERROR] /Users/katrinleinweber/forks/ami3/src/main/java/org/contentmine/eucl/sternLibrary/data_structure/ThriftyList.java:[1043,30] reference to toArray is ambiguous
[ERROR]   both method <T>toArray(java.util.function.IntFunction<T[]>) in java.util.Collection and method <U>toArray(U[]) in org.contentmine.eucl.sternLibrary.data_structure.ThriftyList match

which also occured before my commits.

petermr commented 4 years ago

On Tue, Nov 19, 2019 at 7:01 PM Katrin Leinweber notifications@github.com wrote:

Follow-up to ContentMine/norma#75 https://github.com/ContentMine/norma/pull/75. I search-and-replaced automatically, so I might have caught DOI strings that might be more useful to keep in the old form. In tests maybe?

What was the problem? a change of the DOI URL? Thanks for catching this.

Also, 33c1453 https://github.com/petermr/ami3/commit/33c1453575331ff9577c1a9930c104fc03dfdecd & b2a04e4 update a DOI reg-ex to hopefully be more useful.

I ran mvn clean install and saw no DOI-related errors, but:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project ami3: Compilation failure [ERROR] /Users/katrinleinweber/forks/ami3/src/main/java/org/contentmine/eucl/sternLibrary/data_structure/ThriftyList.java:[1043,30] reference to toArray is ambiguous [ERROR] both method toArray(java.util.function.IntFunction<T[]>) in java.util.Collection and method toArray(U[]) in org.contentmine.eucl.sternLibrary.data_structure.ThriftyList match

I don't think the code is actually used. I'm guessing the problem is a stricter version of the compiler.

You can view, comment on, or merge this pull request online at:

https://github.com/petermr/ami3/pull/6 Commit Summary

  • Hyperlink DOIs to preferred resolver

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/petermr/ami3/pull/6?email_source=notifications&email_token=AAFTCS2NRJNKJGIS7Q2I5TLQUQZXJA5CNFSM4JPH36TKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2N6GCQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFTCSZTZO73U7QU3PG2NPTQUQZXJANCNFSM4JPH36TA .

-- Peter Murray-Rust Founder ContentMine.org and Reader Emeritus in Molecular Informatics Dept. Of Chemistry, University of Cambridge, CB2 1EW, UK