petermr / dictionary

Collection of Wikidata-based dictionaries for scientific annotation and searching
Apache License 2.0
7 stars 4 forks source link

Update.py needs a bit of mending #14

Closed ayush4921 closed 3 years ago

ayush4921 commented 3 years ago

It should be parallel to the structure present in this repository

petermr commented 3 years ago

This is not clear. Do not use "it" - it is not clear what "it" is? if it's Update.py, say so. And is it capitalized? What is the issue? "needs a bit of mending" carries no precise information. "parallel to the structure" is unclear. What structure? where?

Please revise the issue giving filenames, directory structures if necessary. And what is the reason?

ayush4921 commented 3 years ago

Oh yes, It was before we started working on pyamidict. Now we have got a robust project structure. Earlier the files that you committed were using some files that were not yet present in this github repo. I think it shouldn't be an issue now.