Open ml-evs opened 2 years ago
Hi @ml-evs ! Thanks alot for the example. I have successfully implemented this in pygetpapers.
Hi @ayush4921, received your email so I will continue adding some comments on these issues, if that is okay with you!
It looks like you have handled both my points above. One additional note about your setup.py: it might be useful to include a python_requires
field to say which Python versions you support (in practice, the ones you are automatically testing it with, as your support for different Python versions will strongly depend on your dependencies). So maybe python_requires>=3.8
? You can then remove the "trove" tags (e.g. lines like :: Python :: 3.4
) for 3.4, 3.5 etc. that are used for filtering on PyPI.
As a second part of an unofficial JOSS pre-review, you might consider tweaking the way you package up this project, in the following ways:
requirements.txt
file, for example, whilst leaving the versions more open in your setup.py. This would also allow you to automatically perform tests on new versions of your dependencies (which again can be automated using e.g. dependabot through GitHub directly).