search

peterolson / BigInteger.js

An arbitrary length integer library for Javascript
The Unlicense
1.12k stars 187 forks source link

Typescript: toString must have 2 params #175

Closed pashinin closed 5 years ago

pashinin commented 5 years ago

https://github.com/peterolson/BigInteger.js/blob/bf283df222ec54ec464a82234a26947f679edaac/BigInteger.d.ts#L362

Actually toString() method accepts second param - alphabet. But Typescript linter gives an error now if given 2 arguments:

Expected 0-1 arguments, but got 2.
pashinin commented 5 years ago

https://github.com/peterolson/BigInteger.js/pull/176

peterolson commented 5 years ago

Thanks for pointing that out! I merged your pull request.