search

peterprokop / SwiftOverlays

SwiftOverlays is a Swift GUI library for displaying various popups and notifications
MIT License
631 stars 83 forks source link

Swift3 #22

Closed francoisduchemin closed 7 years ago

francoisduchemin commented 7 years ago

Hey Peter, thanks for your library. Do you know how to include the swift 3 branch in carthage?

I tried to put the following string in my cartfile: github "peterprokop/SwiftOverlays" "swift-3.0"

But when I update I get the following error messages: SwiftOverlays/SwiftOverlays/SwiftOverlays.swift:303:27: error: value of type 'CGRect' has no member 'offsetInPlace' SwiftOverlays/SwiftOverlays.swift:310:27: error: value of type 'CGRect' has no member 'offsetInPlace' SwiftOverlays/SwiftOverlays/SwiftOverlays.swift:415:58: error: cannot call value of non-function type 'UIColor' SwiftOverlays.swift:418:70: error: cannot call value of non-function type 'UIScreen' SwiftOverlays/SwiftOverlays.swift:490:42: error: cannot call value of non-function type 'UIApplication'

Thanks, Francois.

ibakurov commented 7 years ago

The same is happening with CocoaPods.

emonfil87 commented 7 years ago

The same is happening with Manually installation.

ibakurov commented 7 years ago

changing offsetInPlace to offsetBy solved the issue.

peterprokop commented 7 years ago

@francoisduchemin @illyaBakurov @emonfil87 Guys, I've updated swift-3.0 branch, can you please check again? Will update CocoaPods when will have some free time.

levibostian commented 7 years ago

@peterprokop I ran the newly updated swift-3.0 branch and it works great from my testing. Simple overlay with text and then removing it.

francoisduchemin commented 7 years ago

@peterprokop Same here everything is working fine with the the updated swift-3.0 branch. Thanks!

giacgbj commented 7 years ago

@peterprokop What about merging this branch into the head?

peterprokop commented 7 years ago

@giacgbj sorry for the delays, was really busy. swift-3.0 is now merged to master

giacgbj commented 7 years ago

@peterprokop Great! Waiting for the release to cleanup my Podfile :-)

peterprokop commented 7 years ago

@giacgbj Can you please check https://github.com/peterprokop/SwiftOverlays/releases/tag/3.0.0 ?

giacgbj commented 7 years ago

@peterprokop I just tested the methods I use in my application and they seem to work properly. In my opinion, you can release it.

kevinkowalew commented 7 years ago

I installed the most recent version (2.0.1) using Cocoapods, however, it appears to not be the updated Swift 3 version. Any ideas why this may be happening?

peterprokop commented 7 years ago

@kevinkowalew I still haven't updated the pod specs, will do that this evening (hopefully)

kevinkowalew commented 7 years ago

sounds great Peter, thanks!

lucletruc commented 7 years ago

@peterprokop agree with kevin, please fix faster :)

peterprokop commented 7 years ago

@kevinkowalew @lucletruc Guys, I've pushed new podspec. Can you please check if everything works as expected?

lucletruc commented 7 years ago

@peterprokop ran pod update works like a charm 👍 :) thanks

kevinkowalew commented 7 years ago

same here, thanks Peter!