search

peterprokop / SwiftOverlays

SwiftOverlays is a Swift GUI library for displaying various popups and notifications
MIT License
630 stars 83 forks source link

iPhone X display #43

Open namanhams opened 6 years ago

namanhams commented 6 years ago

On iPhone X, the notification view should be displayed a bit lower, otherwise it can't by fully seen. Is there anyone having the same issue, or am i missing something here ? There's no one report about this issue, which seems strange to me.

peterprokop commented 6 years ago

@namanhams thanks for reporting this. What installation method do you use? I just checked out library, for me X looks OK: simulator screen shot - iphone x - 2018-02-01 at 16 29 29

namanhams commented 6 years ago

@peterprokop : sorry for my late reply. I missed the notification email. So i used the branch 'Swift-3.0'. This is from Pod : pod 'SwiftOverlays', :git => 'https://github.com/peterprokop/SwiftOverlays.git', :branch => 'swift-3.0'

The function that i use is showAnnoyingNotificationOnTopOfStatusBar

I checked the source code (both branches), i couldn't find you use "safeAreaInsets" or "topLayoutGuide" anywhere, so wonder how you handle the top area in iPhone X.

namanhams commented 6 years ago

@peterprokop : does you view extend under the status bar ?