peterqliu / threebox

A three.js plugin for Mapbox GL JS, with support for basic animation and advanced 3D rendering.
MIT License
526 stars 320 forks source link

Ensure we can share Geometry between objects #3

Closed kronick closed 7 years ago

kronick commented 7 years ago

Examples and all core code should not change the underlying geometry buffers (by rotation, scaling, etc). All project/unproject and higher level animation code should only change the Object3D instances managed by threebox.

For example, this won't work: https://github.com/peterqliu/threebox/blob/master/src/Threebox.js#L72 (I wrote it and will fix it)

kronick commented 7 years ago

This was fixed in https://github.com/peterqliu/threebox/commit/39189e915a96e8022c6937a417dadece0b321e64