search

peterramsing / lost

LostGrid is a powerful grid system built in PostCSS that works with any preprocessor and even vanilla CSS.
http://lostgrid.org
MIT License
4.5k stars 161 forks source link

Remove deprecated moveTo method #375

Closed thebuilder closed 7 years ago

thebuilder commented 7 years ago

Fixes #372 - Replaced with append on block

What kind of change is this? (Bug Fix, Feature...) Bug fix

What is the current behavior (You can also link to an issue)

372

What is the new behavior this introduces (if any) Removes usage of deprecated Node#before method.

Does this introduce any breaking changes? It shouldn't - change is internal.

Does the PR fulfill these requirements?

Other Comments

peterramsing commented 7 years ago

There are several other things that could be added to this as well such as the PostCSS version bump, and included testing for the new version of Node with Travis. I think that all those things build off this so I suppose let me just do some testing and get this MR merged in.

Thanks!

peterramsing commented 7 years ago

LGTM. I'm not sure what tests could be added to test this? As noted, we should add Node 8 testing to Travis but I can do that in another MR. 👍