search

peterramsing / lost

LostGrid is a powerful grid system built in PostCSS that works with any preprocessor and even vanilla CSS.
http://lostgrid.org
MIT License
4.5k stars 160 forks source link

Increase Coverage and Fix Associated bugs #381

Closed peterramsing closed 7 years ago

peterramsing commented 7 years ago

What kind of change is this? (Bug Fix, Feature...) Tests/Chore

What is the current behavior (You can also link to an issue) Not ideal code coverage

What is the new behavior this introduces (if any) More code coverage

Does this introduce any breaking changes? Nope

Does the PR fulfill these requirements?

Other Comments Starting this as a WIP to see if this increases our code coverage report

codecov[bot] commented 7 years ago

Codecov Report

Merging #381 into develop will increase coverage by 6.59%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #381      +/-   ##
=========================================
+ Coverage     93.4%   100%   +6.59%     
=========================================
  Files           19     19              
  Lines          698    701       +3     
=========================================
+ Hits           652    701      +49     
+ Misses          46      0      -46
Impacted Files Coverage Δ
lib/lost-align.js 100% <100%> (ø) :arrow_up:
lib/lost-column.js 100% <100%> (+9.78%) :arrow_up:
lib/lost-masonry-wrap.js 100% <100%> (+12.12%) :arrow_up:
lib/lost-waffle.js 100% <100%> (+17.04%) :arrow_up:
lib/lost-utility.js 100% <0%> (+2.12%) :arrow_up:
lib/lost-move.js 100% <0%> (+8.69%) :arrow_up:
lib/lost-offset.js 100% <0%> (+21.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 14088bb...c445e10. Read the comment docs.