peterramsing commented 7 years ago

What kind of change is this? (Bug Fix, Feature...) Bugfix

What is the current behavior (You can also link to an issue) Presently lostRowFlexbox is set to lost-row-flexbox (the property), not flex or no-flex (the value) The same is also true for lost-column-flexbox.

What is the new behavior this introduces (if any) It's fixed. All good. Nothing to see here. 😳

Does this introduce any breaking changes? Golly, I hope not.

Does the PR fulfill these requirements?

[x] Tests for the changes have been added
[N/A] Docs have been added or updated

Other Comments So there are various things that I'm finding that are broken while adding tests. (YAY!) ...but does that mean that maybe these things don't need to be there? Long-term question...

codecov[bot] commented 7 years ago

Codecov Report

Merging #385 into develop will increase coverage by 1.08%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop    #385      +/-   ##
==========================================
+ Coverage    90.21%   91.3%   +1.08%     
==========================================
  Files           16      16              
  Lines          644     644              
==========================================
+ Hits           581     588       +7     
+ Misses          63      56       -7

Impacted Files	Coverage Δ
lib/lost-row.js	`100% <100%> (+8%)`	:arrow_up:
lib/lost-column.js	`90.21% <100%> (+3.26%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0cf2579...293cd92. Read the comment docs.

peterramsing commented 7 years ago

Daw crumbs...I just found this bug in lost-column. Yay for increasing test coverage!

peterramsing / lost

Fixes issue where long-form flex isn't being set correctly #385

Codecov Report