peterramsing / lost

LostGrid is a powerful grid system built in PostCSS that works with any preprocessor and even vanilla CSS.
http://lostgrid.org
MIT License
4.5k stars 160 forks source link

Adds new lost-vars functionality. #389

Closed steve-holland closed 7 years ago

steve-holland commented 7 years ago

What kind of change is this? (Bug Fix, Feature...) Feature.

What is the current behavior (You can also link to an issue) Solves #376. Future replacement for $lost-gutter and $lost-gutter-local variables.

What is the new behavior this introduces (if any) New lost-vars method to output variables.

Does this introduce any breaking changes? No.

Does the PR fulfill these requirements?

Other Comments I've updated lg-gutter so that it shares same functionality as new lost-vars method, save duplicating code. Only thing I'm not sure you'll like is how I've broken out each of the new variable methods into its own file. See what you think, I can always change it if you aren't keen.

codecov[bot] commented 7 years ago

Codecov Report

Merging #389 into develop will increase coverage by 0.35%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #389      +/-   ##
===========================================
+ Coverage    91.66%   92.02%   +0.35%     
===========================================
  Files           16       19       +3     
  Lines          672      702      +30     
===========================================
+ Hits           616      646      +30     
  Misses          56       56
Impacted Files Coverage Δ
lib/lost-vars.js 100% <100%> (ø)
lib/lost-vars-gutter-local.js 100% <100%> (ø)
lib/lost-vars-gutter.js 100% <100%> (ø)
lib/lg-gutter.js 100% <100%> (ø) :arrow_up:
lost.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c63edbf...f0ae605. Read the comment docs.

equinusocio commented 7 years ago

What release will include this feature?

peterramsing commented 7 years ago

At this point, since it's done I don't see why it has to wait for 8.3. I'm the holdup on 8.2 and getting the test coverage up #381. 😳