search

peterschutt / sqladmin-litestar-plugin

Litestar plugin for the SQLAdmin library
MIT License
18 stars 0 forks source link

Change wrapped app routing #17

Closed Rey092 closed 3 months ago

Rey092 commented 5 months ago

The wrapped app routing has been changed to use admin.base_url instead of the root ("/") to fix a few routing issues. Issue: https://github.com/peterschutt/sqladmin-litestar-plugin/issues/15

peterschutt commented 3 months ago

Hi @Rey092 - sorry its taken me a while to get around to looking at this.

I understand the change and am happy to do it here, although I wonder if this is something that should also be looked at from the litestar routing side (i.e., that requests to paths that are explicitly registered on the litestar application side should be routed to the litestar handler for that path before sending it through an asgi app mounted on the same node of the route trie).

Nonetheless, I'll get this merged, there's just a few things to tidy up so I'll cherry pick your commit into another branch, get the tests passing and cut a release.

Cheers:)

peterschutt commented 3 months ago

Superseded by #27 - thanks @Rey092!