search

peterschwarz / clj-serial

Simple Serial Access for Clojure
Eclipse Public License 1.0
41 stars 11 forks source link

Reflection cleanup (and readme update) #5

Closed WickedShell closed 8 years ago

WickedShell commented 8 years ago

This is primarily a reflection cleanup, as the runtime cost (both in terms of performance and memory) is hurting me on the lower end devices I'm targeting. The only caution is that to do the cleanup is that I made the assumption that people were only opening up serial ports (and not parallel ports). I believe this is a valid assumption for people using the library, but if it's not please let me know.

Additionally I changed the dereferences of the Port record to use the java object form as that is more performant on accessing members of the record without having any readibility problems.

Finally I updated README.md to remove the on-byte methods that weren't there, and to suggest the use of the close! and listen! forms rather then the deprecated ones.

peterschwarz commented 8 years ago

Looks great - I will test it with my setup as soon as i can. Thanks!