Should have unique no-reassign id

[vinayk047]

It would be very nice if it does not re-assign removed id to future file;

To produce the scenario: -> 1. store file -> 2. remove file stored in step 1 -> 3. store any file

In step 3 it gives me same file id as in step 1. It would be really nice if it does not re-assign same id to any file stored in future.

[petersirka]

Hi @vinaykharecha, I'll try to fix it this week! Thank you!

[vinayk047]

Thank you @petersirka , btw your library is awesome; i really appreciate the work you have done on this.

PS: would you please let me know whenever you merge above changes in master?

[petersirka]

Hi @vinaykharecha, I have updated the whole module. Please download it and test it from GitHub 👍

[vinayk047]

Hi @petersirka.

I think we got confused here.

• Your approach in v1.5.0 was correct i.e. If code has used id 1 than it should never assign that id to any other file in future even if it is free.
• In v1.6.0 you are re-assigning same id if it free; this is wrong approach according to me.

So, in v1.5.0 you did not had re-assign id logic but it still had re-assign id once that means it is bug. let me try to find out exact steps to reproduce it and mean while i think you should rollback free id logic (if you feel it is wrong approach).

Thank you!

[petersirka]

My bad. I have added options for re-assign mode.

My test case:

var id = filestorage.insert('test.txt', new Buffer('Hello World 2', 'utf8'));
setTimeout(function() {
    console.log(id);
    filestorage.remove(id);
    setTimeout(function() {
        id = filestorage.insert('test.txt', new Buffer('Hello World 2', 'utf8'));
        console.log(id);
    }, 100);
}, 100);

1
2
[Finished in 0.3s]

Directory:

Can you write me a small example?

[vinayk047]

@petersirka , yes adding option is much better.

I'll give you small example; but mostly i got issue in cluster mode. So my question is it okay to use this module in cluster mode? or this module should not be used in cluster mode?

[petersirka]

Yes, this module can't be used in cluster. It's a bit complicated. I can do it for Total.js framework only.

[vinayk047]

@petersirka , Yup, getting duplicate issue in cluster mode only

i.e.

setInterval(function () { 
    storage.insert('test.txt', new Buffer('Hello World 2', 'utf8'), null, function (err, id) {
        if (err) {
            console.log(err);
        } else {
            console.log("stored " + id);
            storage.remove(id, function (err) {
                if (err) {
                    console.log(err);
                } else {
                    console.log(id + " removed");
                }
            });
        }
    }); }, 300);

Output with same id's:

Thanks for your valuable time; you can close this issue and perhaps you can mention about cluster mode in REDME.md (If you think that's right)

Thank you!