petersirka / nosql

NoSQL embedded database for small node.js projects
Other
295 stars 48 forks source link

Binary insert with own identifier #12

Closed octplane closed 10 years ago

octplane commented 10 years ago

Hello,

No sure this is worthy but my first idea about writing binaries would be that I could set the identifier. It seems that the current implementation provides its own id generator ( which incidentally contain a # which makes these identifier not 'web-safe').

Let me know what you think of it...

petersirka commented 10 years ago

Hi @octplane, I know what do you mean and you are right. You do not use database# for read (https://github.com/petersirka/nosql/blob/master/index.js#L1902).

PS: I fixed this problem, please update version from NPM. New version v2.0.5. Thanks.

octplane commented 10 years ago

Amazing ! Thanks :) and merry everything :christmas_tree:

petersirka commented 10 years ago

Thanks and likewise :+1:

petersirka commented 10 years ago

Please download a new version from GitHub (https://github.com/petersirka/nosql/releases/) ... NPM has some error.