petersmithca / humhub-basic-chat

Integrated Basic Chat Module for Humhub v1.0+
19 stars 11 forks source link

Few Issues Needed looked at #1

Closed Felli closed 8 years ago

Felli commented 8 years ago

So there are a few issues that happen with this module

Issue #1

Deletes chat message on refresh img img

Issue #2

Doesn't call for user ID to get image nor username. img

petersmithca commented 8 years ago

This is working for me. Are there any errors in logs? I am unable to duplicate. it sounds like the ajax calls are not working correctly. Please also check for console messages

Felli commented 8 years ago

Console message: http://yourdomain.com/index.php?r=humhub-chat/chat/users Failed to load resource: the server responded with a status of 404 (Not Found) Checking logs now.

petersmithca commented 8 years ago

This is what I see:

image

petersmithca commented 8 years ago

Ok somehow the pathing is not working for you, do you have url rewriting enabled? https://www.humhub.org/docs/guide-admin-installation.html

If not it likley currently wont work. I do not intend to support this as its more a proof of concept, but if you do not, you should be able to figure out the proper pathing by looking at some of your other paths and edit the script.js file.

Felli commented 8 years ago

Yes I've got the rewrite enabled.

Felli commented 8 years ago

Hmm could having Humhub installed on a subdomain be causing this?

petersmithca commented 8 years ago

Ok, My bad, for now if you modify the script.js file and change any url references to /humhub-chat/chat/whatever

I'll try to fix tomorrow to make work on both pretty and non pretty urls. Note: you will likely have to clean the cached files from your root assets folder too

petersmithca commented 8 years ago

No I think its pretty urls, i didn't test with those. I will modify tomorrow to make the urls work either way using the registervars ability when I get a moment, too late here for me to think right now

petersmithca commented 8 years ago

It also looks like for me that the javascripts are interefering with the posting in spaces. Another thing to look into. Thanks for your help

petersmithca commented 8 years ago

Ok figured that issue out to, will do a new push tomorrow

Felli commented 8 years ago

Alright, look forward to continuing on testing it. :smile:

Havok75 commented 8 years ago

is now running perfectly

petersmithca commented 8 years ago

Just pushed a couple changes 1) changaed ajax calls to use registered variables so should work on both pretty and non pretty urls 2) made spacing of user avatars a little better in the users online section.

May need to clean root assets cache after updating. Closing this issue now.

Felli commented 8 years ago

Works like a charm, but the image calling hasn't set in yet (I'll have to clear my browser cache and check again later.)

petersmithca commented 8 years ago

Humhub copies all assets from modules to a root assets folder, sometimes the css and scripts do not update when you update the module unless you force delete them

On Sun, Dec 13, 2015 at 4:20 PM, Sarah Tsumayoi notifications@github.com wrote:

Works like a charm, but the image calling hasn't set in yet (I'll have to clear my browser cache and check again later.)

— Reply to this email directly or view it on GitHub https://github.com/petersmithca/humhub-basic-chat/issues/1#issuecomment-164295152 .