petersmithca / humhub-basic-chat

Integrated Basic Chat Module for Humhub v1.0+
19 stars 10 forks source link

massive rebuilding #10

Closed tobciu closed 8 years ago

tobciu commented 8 years ago

massive rebuilding of the structure and using Yii2 and Humhub functionality, added Admininistration so nobody has to rewrite their config ;-)

tobciu commented 8 years ago

feel free to add additional authors :-)

petersmithca commented 8 years ago

Thank you! Wow, I'll have a look when I get home, as for authors I should have done that before, I'm not that used to git

Felli commented 8 years ago

Really love what this brings to the table, the only problem that I'm having is that the "Online Members" is below the messages which messes with the actual chat (Viewing wise), other than this it looks pretty good!

petersmithca commented 8 years ago

@Felli Im not seeing any visual changes or not noticeable to me anyway.

tobciu commented 8 years ago

@petersmithca the only visual change is the submit-button, if sending a message, the button will be disabled and an indicator will be visible

Felli commented 8 years ago

On my end I'm seeing some problems with the bright version of the chat, but not with the dark. lol

Bright

Dark

petersmithca commented 8 years ago

I've merged it. More yours now than mine! Put your name on top in authors On Feb 19, 2016 4:41 PM, "Tobias Johannes" notifications@github.com wrote:

@petersmithca https://github.com/petersmithca the only visual change is the submit-button, if sending a message, the button will be disabled and an indicator will be visible

— Reply to this email directly or view it on GitHub https://github.com/petersmithca/humhub-basic-chat/pull/10#issuecomment-186396935 .

WebCrew commented 8 years ago

woow awesome jobs mates thx @tobciu @petersmithca @Felli What a cool teamwork :+1: