search

petersolopov / carbonara

API for carbon
MIT License
125 stars 32 forks source link

Feat/overrides default config #1

Closed honzahommer closed 4 years ago

honzahommer commented 4 years ago

Use config package to make configuration easy extendable.

petersolopov commented 4 years ago

Thanks for the pr!

To be honest, I'm not a big fan of external dependencies. Only necessary. Adding the config library with config/custom-environment-variables.js file for use environment variables is implicit.

If you should change the carbon URL in your environment, I'll be happy to accept changes like your first commit.

If I don't fully understand your idea, let me know.

honzahommer commented 4 years ago

Ok, see my latest update :-)

petersolopov commented 4 years ago

great, thanks!