Running image without SYS_ADMIN capability

petersolopov / carbonara

API for carbon

MIT License

125 stars 32 forks source link

Running image without SYS_ADMIN capability #5

Closed JosXa closed 3 years ago

JosXa commented 3 years ago

Hi there, great work on the API, I'm liking it so far!

I would like to deploy it on the PaaS Caprover, which is built on Docker Swarm. Your documentation however asks me to use the --cap-add=SYS_ADMIN flag, but that is is completely unsupported on swarm. Is there a way to modify your dockerfile not to rely on that being available? If you could just tell me which steps it is required for maybe I could patch it myself :)

petersolopov commented 3 years ago

Hi @JosXa! I used tips from puppeteer docs.

Seeing other weird errors when launching Chrome? Try running your container with docker run --cap-add=SYS_ADMIN when developing locally

I'm would glad to see pr or advice with fix it :)

JosXa commented 3 years ago

I tried and failed, please keep the Help Wanted label ;)

petersolopov commented 3 years ago

I added --no-sandbox arg for chrome launching. We visit one verified site this should not affect security.