search

peterstace / simplefeatures

Simple Features is a pure Go Implementation of the OpenGIS Simple Feature Access Specification
MIT License
125 stars 19 forks source link

DCEL Optimisation: consider alternate nodeSet data structure #304

Open peterstace opened 3 years ago

peterstace commented 3 years ago

The purpose of the nodeSet data structure is to keep track of XY values in the DCEL. As new XYs are inserted, it searches for existing XYs that are too close together (and merges them if they are).

It is currently implemented as a map from an (int,int) bucket to an XY. When an insertOrGet operation occurs, we look in 9 separate buckets to see if what we're looking for already exists. While this is constant time, it's not particularly fast (since we're doing 9 separate map access operations). The main advantage of the current nodeSet implementation is that it is incredibly simple (both conceptually simple only a few dozen lines of code).

Right now, nodeSet operations take up about 25% of the CPU time needed for the intersection benchmark test.

This task is to experiment with alternate data structures that may be more performant. Potentially the RTree could be tried. Although, because we only have an XY dataset, we could also consider other data structures such as k-d trees.

peterstace commented 3 years ago

Note that a slightly different map structure is now used (see https://github.com/peterstace/simplefeatures/pull/324 for details). I still suspect that a k-d tree would be faster.