search

peterstace / simplefeatures

Simple Features is a pure Go Implementation of the OpenGIS Simple Feature Access Specification
MIT License
127 stars 19 forks source link

Consider removing constructor options #504

Closed peterstace closed 9 months ago

peterstace commented 1 year ago

Right now, there are only 2 constructor options:

The construction options are provided via the functional options pattern via the geometry constructors.

Omit invalid was only really added to "prove" that there was more than one option and therefore the functional options pattern was warranted.

We should consider to:

peterstace commented 1 year ago

Another nice thing about having separate "unvalidated" constructors is that those function signatures don't need an error in the return.

peterstace commented 11 months ago

See https://github.com/peterstace/simplefeatures/discussions/525 for discussion about this.