peterstace / simplefeatures

Simple Features is a pure Go Implementation of the OpenGIS Simple Feature Access Specification
MIT License
127 stars 19 forks source link

Remove `OmitInvalid` constructor option #520

Closed peterstace closed 1 year ago

peterstace commented 1 year ago

Description

This constructor isn't used in any non-trivial way by simplefeatures itself, and isn't used by any known users.

It was introduced artificially to "show" that there are multiple uses cases for constructor options (and thus the function options pattern was warranted). However, the only truly used construction option is DisableAllValidations.

The removal of OmitInvalid is the first step to change how geometries are constructed without validation.

Check List

Have you:

Related Issue

peterstace commented 1 year ago

Thanks for reviewing!