peterstace / simplefeatures

Simple Features is a pure Go Implementation of the OpenGIS Simple Feature Access Specification
MIT License
127 stars 19 forks source link

Don't validate results from GEOS #526

Closed peterstace closed 11 months ago

peterstace commented 11 months ago

Description

Recent versions of GEOS use OverlayNG (NG stands for New Generation) for set operations between geometries (Intersection, Union, etc.). With the introduction of OverlayNG, invalid geometries are no longer frequently produced by GEOS. They are either non-existent, or very rare.

Before this change, the simplefeatures GEOS wrapper validates results from GEOS.

This feels like a misalignment:

This change removes that validation. Users can of course still validate manually by calling the Validate method on the result.

Check List

Have you:

Related Issue

Benchmark Results

Not much to see here. All benchmark results are the same, except for benchmarks for GEOS operations which are now faster (due to the change in validation behaviour).

bench_results.txt

peterstace commented 11 months ago

Thanks for reviewing @albertteoh , I really appreciate it 😁