peterstace / simplefeatures

Simple Features is a pure Go Implementation of the OpenGIS Simple Feature Access Specification
MIT License
134 stars 19 forks source link

Simplify internal representation of Envelope #556

Closed peterstace closed 1 year ago

peterstace commented 1 year ago

Description

This change removes the "XOR NaN" hack. The hack was initially introduced as a performance optimisation, but is fairly complicated.

NOTE: this PR introduces a performance regression of up to 5% for some operations. The performance regression will be fixed in a subsequent PR my modifying how the Envelope method for LineStrings is implemented.

Check List

Have you:

Related Issue

Benchmark Results

results.txt

peterstace commented 1 year ago

Thanks for reviewing!