Postgis comparison tests

peterstace / simplefeatures

Simple Features is a pure Go Implementation of the OpenGIS Simple Feature Access Specification

MIT License

133 stars 19 forks source link

Postgis comparison tests #7

Closed peterstace closed 4 years ago

peterstace commented 5 years ago

We want a way to automatically check behaviour of the library against Postgis behavour. If there are any bugs detected, then we can use the generated test cases to add new unit tests (and fixes). There are a few steps to do this:

Parse the existing library for strings that can be used as WKT/WKB/GeoJSON. This will form the initial test corpus.
Create additional Geometries for the test corpus randomly or via enumeration.
Write test harnesses that use the test corpus to check the behaviour of the library against the behaviour of Postgis.

It may make sense to have this as a separate package so that it's no run with the existing tests (especially if the corpus takes a long time to run through).

peterstace commented 5 years ago

Remaining methods that need to be added:

Method	Notes
`Intersection`	Waiting on https://github.com/peterstace/simplefeatures/issues/21
`Intersects`	Waiting on https://github.com/peterstace/simplefeatures/issues/21
`Equals`	Waiting on https://github.com/peterstace/simplefeatures/issues/21
`EqualsExact`	No blockers.
`IsValid`	Requires structural changes, since only valid geometries are included in corpus.

peterstace commented 4 years ago

We currently have postgis comparison tests for all implemented algorithms.