petertalbanese / SoundSwapper

Allows the user to replace sounds with custom .wav files.
BSD 2-Clause "Simplified" License
1 stars 4 forks source link

Music Tracks support #11

Open jacobholden opened 1 year ago

jacobholden commented 1 year ago

Hi, Can you add a feature to blacklist music tracks? And potentially an option to mute all music tracks? I wanna listen to the jingles without listening to the music. Would love it if you add it.

petertalbanese commented 1 year ago

Sorry for the super long delay on this! Been really busy 😅 I'll take a look this weekend!

jacobholden commented 1 year ago

@petertalbanese no worries man appreciate it, I'm really excited (no pressure) ❤️

petertalbanese commented 1 year ago

Hey, I was taking a look at this, but not quite sure I understand what you mean when you say that you "wanna listen to the jingles without listening to the music". What do you mean by "jingles" here?

I've just put up a review to add a mute for Ambient Sounds (things like Magic Trees). Ambient Sounds and Music Tracks seem to work differently from Sounds and Area Sounds. They cannot be consumed in the same fashion. Because of that, this is just a general mute for Ambient Sounds, not a whitelist/blacklist/swap situation. I assume the same will be true for Music Tracks, but I'll take a look and report back.

jacobholden commented 1 year ago

@petertalbanese Apologies I'll be a bit more descriptive.

You know when you play with music sound on, you hear the music tracks in OSRS? And also when you level up, complete a quest, complete a clue scroll, etc. You hear a short "jingle / short music" that stops the current music track from playing. When the jingle is complete, the music track restarts.

The problem is, if you want to listen to those jingles, then you're forced to listen to those music tracks as well.

What I want as a desired feature, is to listen to those jingles, and mute all of the music tracks that are played by the game. That way I get some extra dopamine when I level up by being able to listen to those nostalgic level-up jingles without having to blast my ears with Runescape's music tracks.

Hope that helps, if you have anymore questions please just let me know. :)

edit: here's an example of a jingle: https://oldschool.runescape.wiki/w/File:Attack_level_up_(normal).ogg

petertalbanese commented 1 year ago

Oh that makes sense! Thanks for the explanation 😃 I'll see if I can figure something out.

Might be a bit hard to test since the sounds are pretty infrequent, but maybe we can come up with something a bit more common to try it with... Tourney worlds or something? Let me know if you have any ideas!

jacobholden commented 1 year ago

@petertalbanese Here are some easy repeatable jingles that will be useful to test with:

I think those are some viable ones to test with when developing, especially the one for entering your POH. :)