search

petertodd / python-bitcoinlib

Python3 library providing an easy interface to the Bitcoin data structures and protocol.
Other
1.81k stars 620 forks source link

Bignum handling is dodgy #18

Open petertodd opened 9 years ago

petertodd commented 9 years ago

Doesn't appear we handle bignums > 32bits correctly, and the code itself is uncommented, undocumented, and doesn't handle errors in any sane way.

posita commented 9 years ago

I might have misunderstood the purpose of this issue, but other than creating a dependency, is there a reason not to use pyOpenSSL pyca/cryptography as an interface to the various BN_* calls? (See my comment on #30.)

petertodd commented 9 years ago

@posita The BigNum handling doesn't need an external dependency, especially how that Bitcoin Core doesn't actually use it. What needs to be done is just a review/cleanup of the code itself; this issue is just to remind me I have something outstanding to fix!