petertodd / python-bitcoinlib

Python3 library providing an easy interface to the Bitcoin data structures and protocol.
Other
1.84k stars 625 forks source link

Segmentation fault when calling VerifyScript function #285

Closed noahfx closed 1 year ago

noahfx commented 1 year ago

Hey o/

I'm the maintainer of python-bitcoinlib Debian package. Currently I'm preparing the vesion0.11.2 to be uploaded to the Debian archive.

When building the python-bitcoinlib I've noticed three tests failing with Segmentation Fault, what these tests have in common is a call to VerifyScript function, I'm not sure what's causing the failure.

The failing tests are:

I'm using OpenSSL 3.0.7

Cheers

petertodd commented 1 year ago

I'm using OpenSSL 3.0.7

You mean the openssl package is v3.0.7 right? I personally only test with Debian bullseye, which is still on v1.1.1 so I haven't run into that yet.

What those tests all have in common is VerifyScript, and more specifically, exercising very weird pubkeys/signatures. So likely there is something broken there.

Does Debian have any VPS's available for debugging? I don't have a Debian sid machine handy.

petertodd commented 1 year ago

Fixed: https://github.com/petertodd/python-bitcoinlib/releases/tag/python-bitcoinlib-v0.12.0

I also fixed one more incompatibility with OpenSSL v3. Let me know if the v0.12 release is sufficient for what you need with Debian.

petertodd commented 1 year ago

I see that v0.11.2 is now on Debian; closing. Thanks!