search

petertriho / cmp-git

Git source for nvim-cmp
MIT License
399 stars 23 forks source link

Curl as fallback #34

Closed ner0-m closed 2 years ago

ner0-m commented 3 years ago

Hi, I'm back, finally found the time to do something, which bothered me a little.

Now, if gh or glab fail for some reason, (e.g. setting up authentication with. gh auth login), then curl will be called. While doing that, I've moved some more independent code into utils, which by now is a little big and I'm not sure if everything should be there. But I didn't feel like creating a new file yet.

Lastly, I setup the plenary logging module and sprinkled some debug lines in the places I've made changes.

I've tested it only for like 10 minutes, so if you find any errors, please let me know. And any feedback is welcome!

petertriho commented 3 years ago

This looks like good idea. I will be away for a few weeks (currently in the process of moving) so I can't test this. We could eventually change utils into a folder if that helps

ner0-m commented 3 years ago

No worries, I'll test it today a little more and on another device. And if it's fine I'll merge it.

Yeah maybe something like that would help, but it's not super important for now.

petertriho commented 2 years ago

Sorry this took way too long! Thank you for the PR