search

petertrr / kotlin-multiplatform-diff

Multiplaform kotlin library for calculating text differences. Based on java-diff-utils, supports JVM, JS and native targets.
Apache License 2.0
84 stars 5 forks source link

Update build configuration to reflect KGP improvements #102

Closed lppedd closed 6 months ago

lppedd commented 6 months ago

I did a bit of a cleanup of the build scripts.
Removed what wasn't necessary, centralized all dependencies in the root version catalog, and applied a more specific configuration to the JVM target.

lppedd commented 6 months ago

Just as a note for potential improvement: I've seen you build and deploy using multiple runners.
You could simplify it by using only the MacOS host, which can build for all targets.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.30%. Comparing base (2d978a9) to head (2e85763).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #102 +/- ## ========================================= Coverage 85.30% 85.30% - Complexity 109 110 +1 ========================================= Files 14 14 Lines 524 524 Branches 89 89 ========================================= Hits 447 447 Misses 53 53 Partials 24 24 ``` | [Flag](https://app.codecov.io/gh/petertrr/kotlin-multiplatform-diff/pull/102/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Trifanov) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/petertrr/kotlin-multiplatform-diff/pull/102/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Trifanov) | `85.30% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Trifanov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lppedd commented 6 months ago

Once this PR is merged, I'll submit another one with a bit of code cleanup. No feature changes, just cleanup.
And after that preparation PR, I'll port the algorithm variant.