Closed lppedd closed 1 month ago
Attention: Patch coverage is 94.21769%
with 17 lines
in your changes missing coverage. Please review.
Project coverage is 86.07%. Comparing base (
875f4ce
) to head (37933be
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm done with this one. The refactor: clean up DiffRowGenerator commit has a bit of changes but they're mostly to remove "untyped" lambdas.
This PR is a breaking API change for DiffRowGenerator
.
what's the breaking change in the DiffRowGenerator
It's just the constructor, we introduced new interfaces so I'm not sure it would work straight away.
Edit: well, the new interfaces are not only there, so I'd say this is a general breaking change, but, guess it's ok!
@petertrr np. I have another PR with a small cleanup and then it would be cool to do a release imo!
Ah I see you already released ahaha, well no problem, will be for another minor release.
This PR requires #111 to be merged first.
I will then rebase.