search

petertrr / kotlin-multiplatform-diff

Multiplaform kotlin library for calculating text differences. Based on java-diff-utils, supports JVM, JS and native targets.
Apache License 2.0
74 stars 5 forks source link

add ARM cpu targets #115

Closed dobe closed 3 weeks ago

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.07%. Comparing base (2e5d985) to head (840e5c1).

:exclamation: Current head 840e5c1 differs from pull request most recent head 21f9c47

Please upload reports for the commit 21f9c47 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #115 +/- ## ========================================= Coverage 86.07% 86.07% Complexity 221 221 ========================================= Files 30 30 Lines 632 632 Branches 117 117 ========================================= Hits 544 544 Misses 59 59 Partials 29 29 ``` | [Flag](https://app.codecov.io/gh/petertrr/kotlin-multiplatform-diff/pull/115/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Trifanov) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/petertrr/kotlin-multiplatform-diff/pull/115/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Trifanov) | `86.07% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Trifanov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lppedd commented 3 weeks ago

What about adding all native targets?
Since @petertrr already deploys Apple targets, it should be possible to activate all of them (Tier 1/2/3).

Just need to be careful with automation, to avoid testing the same stuff 20 times.

dobe commented 3 weeks ago

@lppedd i agree with you, however as you say, i am also not aware about the overhead that is introduced here when adding additional targets. So I was adding just the ones that i currently need since i actually tested these. @petertrr please see this merely as a request to add at least those targets. Thanks upfront.

petertrr commented 3 weeks ago

@dobe could you also update the list of targets in the readme (or enable editing of the PR by maintainers)?