search

peterus / platformio_dependabot

MIT License
6 stars 4 forks source link

PR created with no changes #4

Closed jeremypoulter closed 3 months ago

jeremypoulter commented 4 months ago

I have resently added a workflow using this action and it created 4 PRs, but 3 of these contained no changes, despite the summary/description giving detils of the updates. See:

jeremypoulter commented 4 months ago

I think I know the reason: https://github.com/peterus/platformio_dependabot/blob/main/platformio_dependabot/platformio.py#L44-L45 These lines expect the library format to be library @ 1.2.3, most of the libraries I use are library@123 with no spaces.

jeremypoulter commented 4 months ago

Note there are also other formats like library@^1.2.3 for example, see https://docs.platformio.org/en/latest/core/userguide/pkg/cmd_install.html#cmd-pkg-install-specifications

Laxilef commented 3 months ago

Hi @peterus Same problem, any news?

peterus commented 3 months ago

Thanks @Laxilef for the PR. I think we can close the ticket 😊