peterwebster / henson

Master data store for the Hensley Henson Journals project, and issue tracker. The application code is kept elsewhere.
1 stars 1 forks source link

Display of annotations without narrative #216

Closed peterwebster closed 5 years ago

peterwebster commented 5 years ago

As discussed, there are three options for this.

First (and most expensive in dev time) is to have an option, from people/person123 (and equivalents for other types), to Reveal All. This runs through the index, then through the XML containing instances of person 123, rewriting the element to remove/override the display=no attribute. Not favoured.

Second: on loading a journal entry, application checks whether the narrative field for the annotation has any text in it, and if not, the popup icon is not shown.

peterwebster commented 5 years ago

Third (and my favoured option) is to amend the current popup such that, if the annotation is effectively empty, the space closes up,.

For all annotations exception <ref, the test is: is the Narrative field empty? For <ref, the test is: are all three of the date fields empty?

If these tests are positive, then the popup shows:

(i) the name

(ii) See other journal mentions (as at present) (iii) Cross-references (as at present)

peterwebster commented 5 years ago

NOT YET A REQUIREMENT; logging options for reference. @nomoregrapes