search

peterwebster / henson

Master data store for the Hensley Henson Journals project, and issue tracker. The application code is kept elsewhere.
1 stars 1 forks source link

Link to New Note from existing #220

Closed peterwebster closed 5 years ago

peterwebster commented 5 years ago

For discussion next time (to see how much time there is available) @nomoregrapes : to create an 'Add New Note' option that works in the same way as New Person, New Reference etc.

peterwebster commented 5 years ago

Ah, no, found it: so, requirement is to add a link to https://henson.durham.ac.uk/notes/new from the footer of existing ones, to match the other annotation types. @nomoregrapes

ie. from here https://henson.durham.ac.uk/notes/note12

nomoregrapes commented 5 years ago

Actually, none had the "New" link on the page for a specific annotation, the link is on the type index page i.e. https://henson.durham.ac.uk/notes/ There isn't a menu link to the Notes page so that's why it's probably not found.

Nevertheless, I've added a "New x" link to those specific annotation pages, for all types (People, Notes,....)

Deployed to test-server, will be on production when we deploy there.

peterwebster commented 5 years ago

@nomoregrapes found the link from /notes/note123 to notes/new - that's great, thanks.

But right now there is a 500 error if one tries to create a new note from notes/new. Possibly related to #218

peterwebster commented 5 years ago

I created new persons and new places OK, so it would seem that the issue is only with notes/new

nomoregrapes commented 5 years ago

Not related to that. This was a typo in the code for creating notes.

Fixed now, and on test-server.

peterwebster commented 5 years ago

Great @nomoregrapes this is fine now. Closing ticket.