Rearrangement of date picker

peterwebster / henson

Master data store for the Hensley Henson Journals project, and issue tracker. The application code is kept elsewhere.

1 stars 1 forks source link

Rearrangement of date picker #223

Closed peterwebster closed 5 years ago

peterwebster commented 5 years ago

As discussed:

All drop downs to default to [select year / select month / select day] (I realise this will pull the sizing around)
Select a particular day [to match the narrative text above] [ select year / select month / select day ]
Select a range of dates [box A to box B as it is at the moment.] [

nomoregrapes commented 5 years ago

This is now done and on testing

I've been able to simplify the code so it's more readable/maintainable
The date search should correctly find dates within multi-day-journals where it wasn't always doing that before.
If any option is unset, it will use 1900/Jan/01 as needed.
The top of the results should now report the date searched for, with an X so you can remove the constraint.

peterwebster commented 5 years ago

@nomoregrapes this looks good to me, and Katie has had a look to. Go ahead and do the same on WP.

peterwebster commented 5 years ago

@nomoregrapes although, perhaps align the search box on the left with the headings and the two picker boxes below it; in FF it is slightly displaced left.

nomoregrapes commented 5 years ago

Fixed that alignment issue. Just need to copy this to WP now.

nomoregrapes commented 5 years ago

Done on WP. Back to you.

peterwebster commented 5 years ago

Tested and working fine on WP, and looks good on mobile. Closing this down now.