search

peterwebster / henson

Master data store for the Hensley Henson Journals project, and issue tracker. The application code is kept elsewhere.
1 stars 1 forks source link

Attempts to access management pages to redirect to homepage #224

Closed peterwebster closed 5 years ago

peterwebster commented 5 years ago

We should review all the pages such as the dashboard, annotation/new, annotation/1234/edit etc to check that they all redirect to the homepage.

(At the moment, this https://henson-test.durham.ac.uk/journals/new is accessible when not logged in, although one can't save (I think).

Better to redirect here (although less convenient for the team) because we don't really want lots of attempted logins via Github.

peterwebster commented 5 years ago

All the new annotation views redirect correctly.

peterwebster commented 5 years ago

As are all the annotation/edit views. Looks like there's just an issue with the one, journals/new

nomoregrapes commented 5 years ago

Journals the admin check was missing from the new page (and missing if you clicked save). Now added. Not yet pushed to test-server, I'll change this issue from me to Peter when I do that.

As a double-check, I've looked at the code for all other pages and nothing is missing.

peterwebster commented 5 years ago

Looks as though this is pushed to test now @nomoregrapes : all great. Closing ticket now.