petgraph / fixedbitset

A simple bitset container for Rust
https://docs.rs/fixedbitset/
Apache License 2.0
124 stars 47 forks source link

Use Criterion for benchmarks #84

Closed james7132 closed 1 year ago

james7132 commented 1 year ago

This PR changes the benchmarks for the crate to use Criterion instead of the default benchmark harness, as well as added a few more common operations to ensure it covers more of the common operations for the crate.

james7132 commented 1 year ago

CI is failing because criterion cannot compile on 1.39 due to a dependency using the 2021 edition. This is resolvable by:

I'm favoring the second choice here since this seems like an arbitrary reason to bump the user facing MSRV. Though that said, 1.56 is also when they added the rust-version Cargo.toml field, which lets us enforce the MSRV in a salient user-facing way.