Lidarr API client definition

petio-team / petio

Petio Request, Discover, Review

https://petio.tv

MIT License

251 stars 27 forks source link

Lidarr API client definition #718

Open anatosun opened 2 years ago

anatosun commented 2 years ago

This is one of the first step towards Music integration into Petio.

EDIT:

The following PR is a work in progress. Its final goal is music integration into Petio. Here are tentative tasks (i.e., subject to being edited):

[x] Lidarr API client definition
[ ] Lidarr Downloader definition
[ ] Musicbrainz integration
[ ] Frontend adjustments

ADRFranklin commented 2 years ago

I should also mention that we follow a strict commit message structure, and that is conventional commits. I'm surprised you were able to commit at all without husky or commit-cli complaining.

anatosun commented 2 years ago

I made the necessary adjustments:

Removed the commented out code.
Renamed the function.
Changed the commit messages. Furthermore, I believe you're right about this PR not making total sense until the MusicBrainz integration. Let me convert this PR into draft.

ADRFranklin commented 2 years ago

The commit messages still does not follow conventional commits. https://www.conventionalcommits.org/en/v1.0.0/

An example would be Added Lidarr API client definition becoming feat(lidarr): added api definitions