Wonderful work on User Auth, Nikki! I have a few comments below, but these can be addressed after Friday. Let me know if you have questions!
User Auth
Functionality
[x] The main button with logo should link to /
[x] Has working demo login
[x] Smooth, bug free navigation
Before Login
[x] The /login page should not display a link to Log In. Same for /signup
[ ] Going to a random route /#/oweiniouewbrviuwebv should redirect or display a 404 page
[ ] Errors should display for both /signup and /login.
Errors display beautifully for the email page and the login-password form!
However, for the signup-password form, if I only fill out the password and leave out the user name, I'm taken to a blank white page and there are errors in the console: this.props.errors.map is not a function. This is usually a sign that there was some 500-level error thrown on the back end, and your frontend code (errors reducer and React component) can't handle the 500-level error. As with any 500-level server error, check your server log for more info.
[x] Errors should clear when moving between /signup and /login.
[x] Can sign up a user
[x] Can sign in as a user
[x] Can log out a user
[x] Can't sign up with the same username/email
[x] Pressing enter after filling out the session form should use the form data, not the demo user
After Login
[ ] Should not be able to visit any of the frontend urls used for signing up or logging in: /email or /login-password or email-password
You can use your route_utils to achieve this behavior; these should all be AuthRoutes
[x] Should be able to refresh the page and still be logged in
Style
[x] The site should look exactly like the actual site
Styling is magnificent - really on point! I know we talked about how Yummly's signup process is a little weird and doesn't ask for a password right away; it's totally ok to deviate from that and the fix you chose (simulating the two-page signup process and adding the password field to the "How should we call you page") is perfect
[x] All relevant elements should have cursor: pointer on hover
[x] When errors are displayed, most elements should not move around the page (particularly input boxes)
Wonderful work on User Auth, Nikki! I have a few comments below, but these can be addressed after Friday. Let me know if you have questions!
User Auth
Functionality
/
Before Login
/login
page should not display a link toLog In
. Same for/signup
/#/oweiniouewbrviuwebv
should redirect or display a 404 page/signup
and/login
.signup-password
form, if I only fill out the password and leave out the user name, I'm taken to a blank white page and there are errors in the console:this.props.errors.map is not a function
. This is usually a sign that there was some 500-level error thrown on the back end, and your frontend code (errors reducer and React component) can't handle the 500-level error. As with any 500-level server error, check your server log for more info./signup
and/login
.After Login
/email
or/login-password
oremail-password
AuthRoute
sStyle
cursor: pointer
on hover