search

petitparser / dart-petitparser

Dynamic parser combinators in Dart.
https://pub.dartlang.org/packages/petitparser
MIT License
457 stars 48 forks source link

Some dead/uncovered code? #40

Closed mindplay-dk closed 10 years ago

mindplay-dk commented 10 years ago

I noticed the following functions and classes do not have test-coverage and/or do not seem to be in use anywhere:

removeDuplicates()
profile()
progress()
debug()
ContinuationParser
_repeat()

Thoughts?

renggli commented 10 years ago

All code used for debugging grammars.

removeDuplicates() is optimizing grammers for size, but it is currently not used as it is too slow in JavaScript.

Everything you mentioned is optional, of course.

On Thursday, June 26, 2014, Rasmus Schultz notifications@github.com wrote:

I noticed the following functions and classes do not have test-coverage and/or do not seem to be in use anywhere:

removeDuplicates() profile() progress() debug() ContinuationParser _repeat()

Thoughts?

— Reply to this email directly or view it on GitHub https://github.com/renggli/PetitParserDart/issues/40.

Lukas Renggli (mobile) http://www.lukas-renggli.ch

mindplay-dk commented 10 years ago

Right on. I only mentioned it because I've been porting PetitParserDart core again, this time to PHP - it's practically done and all core unit tests are ported and passing, all changes referenced and ported from the last check-in.

It's pretty neat to see all the tests passing - but I have been using the approach of porting the unit-tests first, then porting every component necessary to make the test pass, which left the mentioned features still unported.

I will push this to a public repo soon, just need to clean up and fix a few things :-)

renggli commented 10 years ago

Wow :-)

Thanks gor the reminder. I should indeed write some tests for this functionality. At the time I wrote this there was not possible to redirect 'print(dynamic)', but now this is no longer the case.

Lukas

On Thursday, June 26, 2014, Rasmus Schultz notifications@github.com wrote:

Right on. I only mentioned it because I've been porting PetitParserDart core again, this time to PHP - it's practically done and all core unit tests are ported and passing, all changes referenced and ported from the last check-in.

It's pretty neat to see all the tests passing - but I have been using the approach of porting the unit-tests first, then porting every component necessary to make the test pass, which left the mentioned features still unported.

I will push this to a public repo soon, just need to clean up and fix a few things :-)

— Reply to this email directly or view it on GitHub https://github.com/renggli/PetitParserDart/issues/40#issuecomment-47258928 .

Lukas Renggli (mobile) http://www.lukas-renggli.ch

mindplay-dk commented 10 years ago

Off-topic, but the port is public on GitHub now, listed on Composer/Packagist, and test-suite on TravisCI passing under PHP 5.3, 5.4 and 5.5. Good times :-)

https://github.com/mindplay-dk/petitparserphp

renggli commented 10 years ago

Cool, I've added a link to the readme.txt of the Dart version. I keep this bug open as a reminder to add tests for the untested code you found.

renggli commented 10 years ago

Extracted the debugging code to separate library and added tests in 60cff7be3d5aacae86b0f6842edd2cfb2e493065.