petl-developers / petl

Python Extract Transform and Load Tables of Data
MIT License
1.22k stars 190 forks source link

Fix sorting of rows with different length using custom itemgetter #601

Closed arturponinski closed 2 years ago

arturponinski commented 2 years ago

This PR has the objective of fixing sorting of rows with different length. Closes https://github.com/petl-developers/petl/issues/385

Changes

  1. Changed comparable_itemgetter to fallback to a custom implementation in case of IndexError and KeyError

Checklist

Use this checklist for assuring the quality of pull requests that include new code and or make changes to existing code.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1813523682


Totals Coverage Status
Change from base Build 1813505534: 0.02%
Covered Lines: 12454
Relevant Lines: 13556

💛 - Coveralls