Closed juarezr closed 2 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
petl/io/gsheet.py | 17 | 88 | 19.32% | ||
petl/test/io/test_gsheet.py | 52 | 145 | 35.86% | ||
<!-- | Total: | 72 | 236 | 30.51% | --> |
Totals | |
---|---|
Change from base Build 1865160666: | -1.05% |
Covered Lines: | 12627 |
Relevant Lines: | 13868 |
Great work, a nice feature and some test suite improvements.
I do have a remark or an idea for follow up to issue, to improve the testability. What do you think about using vcr
and casettes, in the same manner as gspread
:
https://github.com/burnash/gspread/tree/master/tests
@arturponinski,
Can you take a look again, please? There are changes in API signatures, pytest and behavior...
This PR has the objective of adding support to Google Sheets
Changes
Caveats
Checklist
Use this checklist for assuring the quality of pull requests that include new code and or make changes to existing code.
tox
/pytest