petl-developers / petl

Python Extract Transform and Load Tables of Data
MIT License
1.22k stars 190 forks source link

Add improved support for working with Google Sheets #615

Closed juarezr closed 2 years ago

juarezr commented 2 years ago

This PR has the objective of adding support to Google Sheets

Changes

  1. Refactored #405
  2. Renamed to/from-gsheet parameters.
  3. Upgraded gspread support from v0.8 to v5.5
  4. Improved the docs about the gsheet

Caveats

Checklist

Use this checklist for assuring the quality of pull requests that include new code and or make changes to existing code.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1966632913


Changes Missing Coverage Covered Lines Changed/Added Lines %
petl/io/gsheet.py 17 88 19.32%
petl/test/io/test_gsheet.py 52 145 35.86%
<!-- Total: 72 236 30.51% -->
Totals Coverage Status
Change from base Build 1865160666: -1.05%
Covered Lines: 12627
Relevant Lines: 13868

💛 - Coveralls
arturponinski commented 2 years ago

Great work, a nice feature and some test suite improvements. I do have a remark or an idea for follow up to issue, to improve the testability. What do you think about using vcr and casettes, in the same manner as gspread: https://github.com/burnash/gspread/tree/master/tests

juarezr commented 2 years ago
juarezr commented 2 years ago

@arturponinski,

Can you take a look again, please? There are changes in API signatures, pytest and behavior...