petl-developers / petl

Python Extract Transform and Load Tables of Data
MIT License
1.22k stars 190 forks source link

Add Support for JSONL Writer #630

Closed mzaeemz closed 1 year ago

mzaeemz commented 1 year ago

This PR has the objective of adding support for writing to JSONL files

Changes

  1. Updated tojson function in petl.io.json to write in JSONL format if lines argument is set to true

Checklist

Use this checklist for assuring the quality of pull requests that include new code and or make changes to existing code.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3126840750


Changes Missing Coverage Covered Lines Changed/Added Lines %
petl/io/json.py 10 11 90.91%
<!-- Total: 42 43 97.67% -->
Totals Coverage Status
Change from base Build 3123360450: 0.02%
Covered Lines: 12750
Relevant Lines: 13993

💛 - Coveralls
juarezr commented 1 year ago

@mzaeemz,

Are you waiting for a release with this change? Current releases in petl are issued based on contributions, not on a fixed schedule. So we usually group some changes and release them.

mzaeemz commented 1 year ago

@mzaeemz,

Are you waiting for a release with this change? Current releases in petl are issued based on contributions, not on a fixed schedule. So we usually group some changes and release them.

@juarezr it's alright, I think the release can wait for a while.

However, there is an open issue for over 2 years now that would be resolved with the release.