search

petlyh / JS-Dict

Japanese-English dictionary app powered by Jisho.org.
GNU General Public License v3.0
51 stars 2 forks source link

F-Droid build failed #14

Closed linsui closed 1 month ago

linsui commented 1 month ago

https://gitlab.com/linsui/fdroiddata/-/jobs/7887028609

Could you please take a look? Thanks!

petlyh commented 1 month ago

Hi. Thanks for letting me know.

It looks like the commit in the build metadata is the latest commit on main, and not the commit that corresponds to the tag. Any idea why that might happen?

I'll have to look into why building that commit failed later, but that's not important for getting the current version on F-Droid, since the build error seem to be specific to the latest commit. (Same error, apparently)

linsui commented 1 month ago

It failed with the same error so I updated the commit trying to fix it.

petlyh commented 1 month ago

I see. Both commits should be fixed now. It would be great if the commit in the build metadata could be changed back to 890587b when it's re-enabled, so that the F-Droid and GitHub releases will match. Thanks!

Note to self: commits used in the forked flutter repo must be tagged so the flutter tool can tell what version the SDK is for dependency resolution.

linsui commented 1 month ago

Thanks!