Closed gallois closed 3 months ago
Got it. I'm afraid I'm a bit time-constrained right now to be able to implement additional changes, mostly because "it works on my machine"™
I'll close this PR for now and keep following https://github.com/petoju/terraform-provider-mysql/issues/112 to ensure I jump back to upstream when it's fixed.
Thanks a lot for the effort in maintaining it :)
This fixes the issue described in https://github.com/petoju/terraform-provider-mysql/issues/112 where it's not possible to import some grants. In short, it:
desiredProcedureGrant
, separating it fromdesiredGrant
, which now becomesdesiredTableGrant
. This is used when trying to find a conflict and can probably be made a bit more generic, but it's likely outside the scope of this change (see below)formatDatabaseName
intoproduceGrantId
which, as the name says, produced the grant id that is going to be used by the provider.id
which was missing and causing the errors that were seen in the issue above.It also fixes a typo in the docs that I introduced earlier.
There are a few things worth noting: