search

petoju / terraform-provider-mysql

Terraform MySQL provider – unofficial fork
https://registry.terraform.io/providers/petoju/mysql
Mozilla Public License 2.0
63 stars 40 forks source link

Add Cloud SQL instances private ip option #122

Closed mario-pany closed 3 months ago

mario-pany commented 3 months ago

GCP Cloud SQL - Add support for PRIVATE_IP #117

Add new bool option private_ip to connect to gcp cloud sql instance with private ip without locally running cloud-sql-proxy

petoju commented 3 months ago

Hi, thanks for your PR!

Could you please:

  1. Fix tests? I believe go fmt will do it. There should be no "cross" signs near circleci results here.
  2. Add documentation?
mario-pany commented 3 months ago

@petoju Thank you for your hint I found a markdown documentations inside the website folder is this the correct place to add the new option?

petoju commented 3 months ago

@mario-pany yes, that is the correct place.

Basically you should document it in the same way other options here are documented.

petoju commented 3 months ago

Released in 3.0.50