search

petoju / terraform-provider-mysql

Terraform MySQL provider – unofficial fork
https://registry.terraform.io/providers/petoju/mysql
Mozilla Public License 2.0
73 stars 48 forks source link

feat: add support for Amazon RDS MySQL config #60

Closed cemdorst closed 1 year ago

cemdorst commented 1 year ago

Implements a new resource called mysql_rds_config that handles Amazons RDS MySQL config parameters that otherwise could only be configured using a local-exec approach. Discussion here #56

petoju commented 1 year ago

Thanks for the PR. There are some things to resolve, but generally, it looks good.

cemdorst commented 1 year ago

Thanks for the PR. There are some things to resolve, but generally, it looks good.

Thanks for considering this contribution and for you review. I think I have the requested changes fixed by 0dc96e08252e1d3c7c6d6ee599054b60cd16aafa . Let me know if looks good.

cemdorst commented 1 year ago

Ok, we're getting there. Once you address my comments, I'll spend my 10 cents to get RDS to run tests on that. Hopefully that will work.

I think I have all addressed. My comment about the "+rds" or empty string got lost: I thought about creating a generic function that would return metadata do the Version (https://pkg.go.dev/github.com/hashicorp/go-version#section-readme). Possibly could be used by serverVersion or serverVersionString.

petoju commented 1 year ago

I release provider version 3.0.30 that includes this PR.

cemdorst commented 1 year ago

I release provider version 3.0.30 that includes this PR.

That's great news!! I am very happy to contribute :-)