petotamas / pyArgus

Antenna array signal processing library implemented in python
https://www.tamaspeto.com/pyargus
GNU General Public License v3.0
164 stars 60 forks source link

Format of array_alignment #9

Open ea4gja opened 1 month ago

ea4gja commented 1 month ago

In antennaArrayPattern.py, line 67, array alignment is said to be a 2D array. In directionEstimation.py, line 778, it is said to be a 1D array. In beamform.py, several points, it is unclear. In my view, the format should always be the same.

ea4gja commented 1 month ago

When the format is always the same, you can add two more functions: gen_uca_array_alignment, and gen_ula_array_alignment. This way, when the user uses an UCA or ULA array, he does not need to know array_alignment format.